This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Fix for invite messages sent from Windows machine #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… characters instead of \n)
There was a problem hiding this comment.
Could it not use something like what is described here to make it a bit more generic?
|
@jeremynorman89 I agree that it might be improved. |
|
I think that would be a better solution still, even if you need to filter empty lines out. |
|
Any updates for this MR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for invite messages sent from Windows machine (with \r\n new line characters instead of \n)
Issue number
{if exists provide related issue}
Expected behavior
Caller name should be parsed successfully from the invite message
Actual behavior
When the invite message arrives with \r\n new lines then it is not parsed properly - each parsed line ends with "\r". It causes the caller name not to be parsed because it doesn't match the corresponding regex in VSLCall.m:758 (the regex is '.+\\s<.+>')
Description of fix
Before the fix in SipInvite.m:89 the invite message was split to separate lines using "\n".
The fix is to check whether the line separators in the invite message are "\r\n" and use it if so.
Otherwise fallback to "\n".
Other info
{anything else that might be related/useful}